Repository navigation
chore(dz): monthly improve checkup; stop two scripts hiding failures - #946
Conversation
- .dz/briefs/improve.md + `schedules: improve` (every Monday 08 UTC; the brief acts only on the first Monday of the month): at most three small, evidenced PRs, never a version bump, never a breaking change, no churn. - wiki.yml: a failed wiki clone printed nothing and always claimed the wiki was never initialised; git's own output is now shown, and only a "not found" answer is read as an uninitialised wiki. - deploy-proof/run.sh: `x deploy`'s exit status was discarded with `|| true`, and a non-JSON answer ended the script at jq with no refusal; the proof now requires exit 0 AND `deployed`, and names the exit status and findings. `bun pm pack` no longer discards stderr, so a failed pack says why. - registry-audit.yml: reason comment on its one deliberate continue-on-error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 54s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 6 file(s), 0 finding(s).
Completed review adds a monthly improvement brief and schedule, exposes wiki clone diagnostics, and preserves deployment exit failures. No concrete defects found in the provided diff.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-dev-marshall — 64.3k in / 391 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.
Monthly
improvecheckup.dz/maintainer/maintainer.yml:schedules: improve,days: [mon],hours_utc: [8]. The schema has weekdays, not days of the month, so it fires every Monday. The brief acts only on the first Monday (UTC day 1-7) and stops on the others. Validated againstmaintainer.v1.json..dz/briefs/improve.md: reads the signals first (gate on freshmain,.bun-versionvs the newest Bun, since Dependabot ignoresbun,bun outdatedmajors,bun run coverage, openbugissues,expectedRedpins that could be unpinned, dated docs claims). Then it picks at most three improvements, in this order: broken or flaky, Bun and dependency majors, correctness (X_*codes, no swallowed errors), measured speed and bytes (axiom 9), docs drift, simplification. Each one ships as its own small PR with evidence. It never bumps the version. It never ships a breaking change: it files an owner issue instead. This is deliberately narrower thanescalate:, because an improvement nobody asked for is not worth a migration for every app. It never touches release or publish automation. If nothing is worth doing, it does nothing..dz/README.mdlists the new brief.health.mdis unchanged: its rows are pinned toscripts/health.tsbyhealth-doc.test.ts, and the monthly check is not a health signal.Hidden-error audit
wiki.ymlpush stepgit clone … 2>/dev/null: every clone failure (auth, network, 5xx) was hidden and reported as "Wiki not initialised"not foundanswer is called an uninitialised wiki. Anything else isWiki clone faileddocker/deploy-proof/run.shdeploy()x deploy … > out || truedropped the exit status. A non-JSON answer killed the script atjqunderset -ewith no refusaldeployed, and the refusal names the exit status, rollout status and findings. Simulated locally with a stub for the deployed, failed, garbage and empty cases.x deployexits non-zero only when helm does, so a real green proof is unaffectedrun.shpackage loopbun pm pack … >/dev/null 2>&1: a failed pack ended the job with no messageregistry-audit.ymlcontinue-on-error: trueon the auditoutcome, file the alarm, thenexit 1. Added a reason commentrelease.yml,deploy-social-demo.yml|| trueongh apirelease.ymlnpm view … 2>/dev/null || truerelease-tag.ymlgh api …/ref/tags 2>/dev/nullci.ymlgrep -c … || true,jq … || truerender,merge --json || trueexit "$status"from the real commandci.ymlfail-fast: falseci.ymlalready has nocontinue-on-error.catch(() => undefined)/catch {}(packages, scripts)skipIfskipIf(true)only in tests of the skip-cleanup guard itself. Live suites skip on unset services, but theverify-floorratchet turns a whole-suite skip into a failureVerification
bun testover the workflow-shape, health-doc, release-due-doc, deploy-proof-due, bun-pin, gate-steps and scaffold-gate tests: 201 pass, 0 failbun run lint: clean apart from 1 existing warning (scripts/lib/health-doc.test.ts:172, also onmain)bun run doc-paths: every path resolvesshellcheck -S warning docker/deploy-proof/run.sh: cleandeploy-proofjob runs onmainonly, so the run.sh change gets its first real run after merge🤖 Generated with Claude Code