fix(ci): preserve existing assets when retrying releases - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrying the 0.3.0 release successfully skipped existing PyPI wheels, but uploading their existing GitHub assets failed with
ReleaseAsset: already_exists. This prevented changepacks from finalizing the draft releases after npm trusted publication succeeded.Use one upload script for npm and Python assets. It reads the existing release asset names, preserves completed nonempty assets, and uploads missing files. Incomplete or empty name collisions fail safely instead of permitting finalization. Missing files and invalid release URLs fail explicitly. Python checks out the repository before invoking the script.
Validation:
npm audit signaturesverified registry signatures and attestations for the CLI and Windows native package.Independent review passed after restricting skips to uploaded, nonempty assets. Main CI run 36824414706 succeeded with all 39 executed jobs passing. Both npm and Python skipped existing packages/assets successfully, and changepacks finalized their 0.3.0 releases.