Repository navigation
fix: reject invalid fill quantities before mutating orders - #20
Merged
Merged
Conversation
dev-belly
marked this pull request as ready for review
October 24, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order.apply_fillaccepted booleans, fractional values and NaN as filled quantity. A NaN fill could silently poison filled and remaining quantities while moving the order state.Require a positive Python integer before any transition or quantity update. Eight invalid-input regressions assert that filled quantity, status and lifecycle timestamps remain unchanged. Existing partial/complete integer fills remain covered.
Validation: the full local Python suite passes 918 tests with 154 compiled/optional skips. The existing PR CI passes Python 3.11–3.13, C++ unit/differential tests, sanitizers, installed distributions and reproducibility. No trading service or order API was contacted.