Repository navigation
fix: validate parent quantity before execution replay - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run --quantity 0 --jsonpreviously exited successfully and simulated the configured default of 20,000 base units. The harness used a truthiness fallback, so an explicit zero was treated as an omitted override.Use the configured quantity only when the override is
None, and reject effective parent quantities that are not positive integers before replay. The CLI also validates--quantityas at least one. Omitted overrides and positive quantities keep their existing behavior; configuration errors use the existing error path.Validation: all 43 focused checks in
test_guards.pyandtest_resources.pypass, including an independent rerun. Of the 22 added cases, 12 fail against the previous implementation; the other 10 preserve already-supported behavior. Coverage includes Python overrides, configured quantities, CLI failures without a traceback or result report, and preservation of defaults and positive overrides.