Repository navigation
Preserve custom report identities in CSV exports and browser selectors - #5
Merged
Merged
Conversation
dev-belly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom names could become spreadsheet formulas, lone CR characters could create unintended CSV records, and HTML preprocessing could collapse CR/LF/NUL identities into another option.
Protect untrusted period/scenario labels in all four CSVs with a visible
text:marker, including locale/control prefixes and collision-safe handling of names already starting with the marker. Preserve embedded CR/LF/CRLF cells while keeping LF record endings. JSON and financial numeric representations retain their original values.Use explicit ASCII JSON selector identities shared by options and result panels, preserving distinct original names through browser preprocessing. Add an actual-Chrome CI check using the runner's matching chromedriver with no extra Python packages. Refresh only saved report HTML and its manifest hash; all source and numerical artifact bytes are unchanged. Document regeneration of earlier reports from saved JSON.
Validation: 39 local tests, Ruff lint/format, committed report replay, preview check, sdist/wheel build and whitespace checks passed. A clean installed wheel verified a formula-named custom report outside the checkout. Real Chrome and cross-platform checks run in this PR's CI.