Repository navigation
Connect the browser notebook to timestamp-safe source - #27
Merged
Merged
Conversation
dev-belly
marked this pull request as ready for review
October 28, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notebook still installed an older source snapshot after the timestamp guard merged in #26. Pin its full source URL to the checked merge 219e58a, and add a runnable counterexample showing that a seventh fractional-second digit is rejected rather than silently truncated.
Keep the original three invoice decisions and editable timing scenario. Document the supported precision beside the editable fields. Save no notebook outputs or execution state.
Validation: scripts/check_notebook.py compiles every cell, checks stable unique IDs and executes all four ordinary code cells against the new source. The original selections and SQL/reference equality pass; the new cell explicitly fails if unsupported precision is silently accepted. The pinned installation also runs successfully in a fresh virtual environment with no PITBridge preinstalled: all five code cells, including the real source download/install, complete and the imported package is inside that environment. This checks the notebook installation and cells locally, rather than claiming a hosted Colab UI run. This is a synthetic timing lesson, not a model-performance claim.