Repository navigation
Bind review conclusions to evidence and reject stale submissions - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
A finding can retain its stable ID when linked source values change. Its last closed review previously remained current after a rule rerun, even though that decision assessed different evidence.
Bind each new review to the complete automated finding fingerprint and keep every earlier review in history. Changed evidence now returns the current finding to pending; identical reruns preserve its decision. The workbench records the displayed review revision and requires an explicit reload after another review or evidence change. Revision validation, review insertion and evidence binding commit atomically, with a real per-finding write increment rejecting simultaneous saves of the same revision.
Portable evidence and compatibility
Format 3 bundles include review evidence bindings. Verification replays source rows, recomputes the current fingerprint and derives the applicable decision before comparing CSV and workpapers. Format 2 / version 0.2.7 remains verifiable and is explicitly reported as unbound. Legacy databases keep their review history but require reassessment because their original evidence fingerprint was never recorded. Historical source snapshots, reviewer authentication and signatures remain outside scope; this is a local synthetic audit workbench.
Validation
git diff --checkpass.