Repository navigation
fix: respect converter host environment in restricted sandboxes - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deckuse forced a fresh temporary .NET bundle extraction cache even when direct deck2html invocations could reuse the host runtime cache. On restricted hosts, bundle commit operations could fail before conversion or browser startup.
This change inherits the host extraction environment, shares converter execution between render and monitor, forwards license arguments, and preserves native exit/signal and extraction-stage diagnostics. Browser preflight cleanup failures are reported as retained-path warnings without masking successful write checks or primary write failures.
Validation: build, TypeScript, changed-source ESLint, formatting and whitespace checks passed; 469 full-suite tests plus the additional license-guard regression passed locally; the installed package smoke passed. A real macOS arm64 multi-file deck2html npm package was packed and installed, tested with denied extraction writes, and used for PPTX/DOCX screenshots through Playwright. Both sample screenshots were pixel-identical to the existing converter. Details are recorded in docs/verification-converter-sandbox.md.
Package acceptance checks now assert successful preflight with retained cleanup warnings. The commercial-code scanner allows only the exact dependency license argument mapping; a regression test verifies all other license markers remain rejected.
The companion deck2html runtime packaging change is in deckflow/deck2html-source commit 08db3f0. Its other platform executions and the original WorkBuddy policy remain unverified. This PR retains the current published dependency range; raising the minimum and refreshing the lockfile follows the new deck2html release. No npm publishing is included.