Repository navigation
Let a long text question have no character limit - #291
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 16, 2026
PhilReinking
left a comment
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 7d58c3d, CI green. In Brave: a new long text question saves 500 once. Clearing it saves max_chars null, and after a reload it opens empty and saves nothing. Old answers with options null or [] open empty, which matches the public form: it already had no limit for them. A saved 500 stays 500. The public form took a 700-character answer. Of the 3 new tests, 2 fail on main's component. Vitest 518 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long text question with an empty "Max characters" now stays empty when you open it again, and means no limit. Before, the editor showed 500 and saved it back. New questions still start at 500. The hint says "No limit" again.
Fixes BITS-298
ConfigureTextarea.vue: a new answer gets 500 once, a saved answer keeps its limit or stays empty. Empty savesmax_chars: null.CharCount.vue,models.d.ts: allownull. The public form and server already read it as no limit.Tested: Vitest, lint and vue-tsc pass; the new tests fail without the fix. In a browser: reopen stays empty, the public form takes 700 characters.
Not tested: PHP suite (no
app/change).