Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ Lines marked **Upgrade step** need you to act after updating.
- The form editor now shows "Saving…", "Saved" or "Not saved" with Retry. A failed save names the question by number and text, and the red bar offers Retry. Reloading or closing the page right after typing keeps the change, and the browser asks before you leave while a change isn't saved. Before, the editor showed nothing, and a reload within a second lost the change. (#267)
- A webhook answer that isn't valid UTF-8 text is now saved and shows on the submissions page, with each unreadable character as "?". Before, it wasn't saved and the webhook was called up to 5 times. With `QUEUE_CONNECTION=sync`, the submission itself failed with a server error. (#284)
- Opening a question in the editor no longer saves its answer settings, so "Saving…" does not show up for nothing. They save only when you change a setting. (#288)
- When a save fails, the red bar with Retry no longer makes the editor taller than your window. The page stays as tall as the window, so your last question and the end screen stay in reach. (#290)

### Security

Expand Down
8 changes: 4 additions & 4 deletions resources/js/Layouts/AppLayout.vue
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<template>
<div>
<!-- the banner and the page share one window-high column, so the banner takes
its space from the page instead of adding to its height -->
<div class="flex min-h-screen flex-col supports-[height:100dvh]:min-h-dvh">
<Head :title="title" />

<jet-banner />

<div
class="flex min-h-screen flex-col bg-grey-50 supports-[height:100dvh]:min-h-dvh"
>
<div class="flex flex-grow flex-col bg-grey-50">
<FormTopBar v-if="form.formId">
<template #save-status><slot name="save-status" /></template>
<template #preview><slot name="preview" /></template>
Expand Down
Loading