Skip to content

fix(react-ui): Button icons follow the button's text color #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sistrall merged 2 commits into from
Sep 30, 2026
Merged

fix(react-ui): Button icons follow the button's text color #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba4a96
fix(react-ui): Button icons follow the button's text color
roger-datocms Sep 29, 2026
94c6359
docs(react-ui): explain why Button icons also set color: currentColor
roger-datocms Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/button-icon-current-color.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"datocms-react-ui": patch
---

`Button` icons now take the button's own text color instead of always using the link color. This fixes accent-colored icons on red `negative` buttons, on `primary` buttons, and on disabled buttons.
6 changes: 4 additions & 2 deletions packages/react-ui/src/Button/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,10 @@
line-height: 0.6;

svg {
fill: var(--color--ink-link);
color: var(--color--ink-link);
fill: currentColor;
/* Not redundant: icons painting via `currentColor` (e.g. FontAwesome) would
otherwise pick up a plugin's own `color` rule on the svg */
color: currentColor;
}
}

Expand Down
Loading