Repository navigation
Refactor/final fixes - #726
Merged
Merged
Conversation
timcadman
marked this pull request as ready for review
October 29, 2026 10:12
…factor/final-fixes
⏳ 4 of 5 checks reported so far
Tested against Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov |
⏳ 0 of 5 checks reported so far
Tested against Logs: pending · pending · pending · pending · pending |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7.0-dev #726 +/- ##
============================================
- Coverage 67.88% 67.88% -0.01%
============================================
Files 131 131
Lines 5073 5076 +3
============================================
+ Hits 3444 3446 +2
- Misses 1629 1630 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
- Changes to ds.mdPattern.R look correct
- Updates to tests appear correct and complete
StuartWheater
self-requested a review
October 30, 2026 11:53
StuartWheater
approved these changes
Oct 30, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
- Changes to ds.mdPattern.R look correct
- Updates to tests appear correct and complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.