Skip to content

Keep check messages brief and move details into results - #477

Merged
monrog2 merged 2 commits into
v4.3.0-devfrom
codex/short-check-messages
Oct 2, 2026
Merged

monrog2 merged 2 commits into
v4.3.0-devfrom
codex/short-check-messages

Conversation

@monrog2

@monrog2 monrog2 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Several checks put lengthy findings, filenames, diagnostic errors, or remediation instructions into msg, overflowing the single-line terminal status output. Keep these check messages brief, use result tables for findings, and place extended instructions and diagnostics in recommended_action.

Apply the reviewed content changes across 27 checks. The shared missing-target-version message remains Target version not supplied. Skipping.. Missing firmware images get an image inventory table; selected collection errors reuse their existing columns with ERR rows. OOB MANUAL results ask users to check connectivity without implying a confirmed failure. Atomic-counter missing-target results explicitly retain the deprecation clarification, including when other findings populate data.

The existing result classifications, JSON schema/mapping, renderer, and data-to-recommended-action display behavior are preserved. Shared exception, check-start, and timeout messages are unchanged. This branch starts from v4.3.0-dev and includes only the approved check-content changes and associated result tests.

Validation:

  • Full local pytest suite: 1,412 passed (Python 3.9).
  • Regression coverage verifies result statuses, missing-image and error rows, and preservation of data and recommended actions in terminal/JSON output.
  • git diff --check passed. Source comparison confirms shared result/serialization/rendering/management code is unchanged.
  • Python 2.7 runtime is unavailable locally; the script and new tests parse with Python 2 grammar. CI supplies the Python 2.7 and 3.8 runtime checks.

@monrog2
monrog2 merged commit a4ac204 into v4.3.0-dev Oct 2, 2026
3 checks passed
@monrog2
monrog2 deleted the codex/short-check-messages branch October 5, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant