Repository navigation
Keep check messages brief and move details into results - #477
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several checks put lengthy findings, filenames, diagnostic errors, or remediation instructions into
msg, overflowing the single-line terminal status output. Keep these check messages brief, use result tables for findings, and place extended instructions and diagnostics inrecommended_action.Apply the reviewed content changes across 27 checks. The shared missing-target-version message remains
Target version not supplied. Skipping.. Missing firmware images get an image inventory table; selected collection errors reuse their existing columns withERRrows. OOB MANUAL results ask users to check connectivity without implying a confirmed failure. Atomic-counter missing-target results explicitly retain the deprecation clarification, including when other findings populate data.The existing result classifications, JSON schema/mapping, renderer, and data-to-recommended-action display behavior are preserved. Shared exception, check-start, and timeout messages are unchanged. This branch starts from
v4.3.0-devand includes only the approved check-content changes and associated result tests.Validation:
git diff --checkpassed. Source comparison confirms shared result/serialization/rendering/management code is unchanged.