Skip to content

fix(docker): probe local ClickHouse health over IPv4 - #962

Merged
izadoesdev merged 1 commit into
stagingfrom
izadoesdev/dev-clickhouse-healthcheck
Sep 27, 2026
Merged

izadoesdev merged 1 commit into
stagingfrom
izadoesdev/dev-clickhouse-healthcheck

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Summary

The dev docker-compose.yaml healthcheck ran wget http://localhost:8123/ping. Inside the container localhost resolves to [::1], but ClickHouse listens on IPv4, so the probe is refused every time and the container reports unhealthy forever (84,642 consecutive failures on one machine) regardless of whether the server is fine. That hides real outages: a ClickHouse that is actually hung looks identical to a healthy one.

docker-compose.selfhost.yml already probes 127.0.0.1 since #804; this applies the same fix to the dev compose file.

Test plan

  • Inside the running dev container: wget --spider http://127.0.0.1:8123/ping succeeds; the localhost form is refused
  • docker compose -f docker-compose.yaml config -q

Summary by cubic

Fixes the dev ClickHouse healthcheck so it probes IPv4 instead of localhost, which resolved to [::1] inside the container and never matched ClickHouse's IPv4 listener. The container now correctly reports healthy; docker-compose.selfhost.yml already used 127.0.0.1.

Written for commit 0aec854. Summary will update on new commits.

Review in cubic

The dev compose healthcheck ran wget against localhost:8123, which resolves
to [::1] inside the container while ClickHouse listens on IPv4, so the
container reported unhealthy forever (84,642 consecutive failures locally)
regardless of the server's state. docker-compose.selfhost.yml already
probes 127.0.0.1 since #804.
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashboard Ready Ready Preview Sep 27, 2026 4:09pm UTC
databuddy-status Ready Ready Preview Sep 27, 2026 4:09pm UTC
documentation Ready Ready Preview Sep 27, 2026 4:09pm UTC

@unkey-deploy

unkey-deploy Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Sep 27, 2026 4:08pm

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9586a7e2-6550-4457-bfa3-04aebbcb0b14

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Changes local health check endpoint address.

The PR appears safe to merge.

Summary

The dev ClickHouse healthcheck now probes 127.0.0.1 instead of localhost, matching the self-hosted Compose healthcheck and avoiding an IPv6 loopback resolution that can falsely mark the container unhealthy.

Reviews (1) · Last reviewed commit: "fix(docker): probe local ClickHouse heal..."

@izadoesdev
izadoesdev merged commit b4dbcf0 into staging Sep 27, 2026
14 checks passed
@izadoesdev
izadoesdev deleted the izadoesdev/dev-clickhouse-healthcheck branch September 27, 2026 16:12

This branch was successfully deployed

4 active deployments
Preview – dashboard — 0aec854e Deployed Sep 27, 2026 by vercel[bot]
Preview – documentation — 0aec854e Deployed Sep 27, 2026 by vercel[bot]
Preview – databuddy-status — 0aec854e Deployed Sep 27, 2026 by vercel[bot]
links - preview — 0aec854e Deployed Sep 27, 2026 by unkey-deploy[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant