Repository navigation
feat(app): Improved Install Flow Github - #141
Merged
Merged
Conversation
The built frontend in frontend/dist is now committed, so deployments need neither Node.js nor access to the npm registry. The app can be installed from GitHub in the Databricks UI, and `databricks apps deploy` installs it from a clone with one command. CI checks that the committed build matches its source. databricks.yml moves the workspace source into the dev target and adds a github target that deploys the checked-out commit from GitHub, for workspaces that only allow app deployments from Git. The install docs cover the one-command and UI installs, upgrades and switching to the github target. Node.js is no longer a requirement. Co-authored-by: Isaac <no-reply@databricks.com>
…step When the pre-flight check finds that the app's service principal lacks access, Grant and run executes the generated GRANT statements as the signed-in user and then starts the run. A statement the user may not run, such as a catalog grant for a schema owner, doesn't stop the others; the first failure is reported only if the service principal still lacks access afterwards. Copy SQL stays for users who may not grant access. Co-authored-by: Isaac <no-reply@databricks.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 68 68
Lines 6076 6076
Branches 759 759
=======================================
Hits 5488 5488
Misses 466 466
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
GitHub doesn't report the checks of a workflow that a paths filter skips, so a required "Test the app" would block every PR that doesn't change the app. The workflow now starts on every PR, and a new changes job checks whether the PR touches apps/adhoc-reporting/ or app.yml. If it doesn't, the test job is skipped, which GitHub counts as passing. Pushes to main and manual runs behave as before. The test job is skipped only for fork PRs, as before, and when the changes job found no app changes. If a job it depends on fails, the tests run, so a failing helper job can't pass the check untested. Co-authored-by: Isaac <no-reply@databricks.com>
tombonfert
approved these changes
Nov 16, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Trade-offs
Tests