Skip to content

feat(app): raise the assistant's step limit from 12 to 20 - #139

Merged
tombonfert merged 1 commit into
mainfrom
feature/app_increase_max_rounds_default
Nov 12, 2026
Merged

tombonfert merged 1 commit into
mainfrom
feature/app_increase_max_rounds_default

Conversation

@tombonfert

Copy link
Copy Markdown
Collaborator

Summary

The app assistant stops after MAX_ROUNDS model calls per user message and asks how to continue. Building a complete report in one message (data, units under test, signals, events, aggregations, validation and run) came close to the old limit of 12, so this raises the default to 20.

  • server/agent/loop.py: MAX_ROUNDS = 20. No other code, tests, skills or docs reference the value.
  • Messages that finish in fewer rounds are unaffected. Messages that need more rounds now cost more, since each round re-sends the conversation.

Tested: app unit tests pass (153).

Test Plan

  • Unit tests added/updated
  • Manual testing completed
  • Documentation updated (if applicable)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No new linter warnings introduced

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (11caf71) to head (f4c5b21).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          68       68           
  Lines        6076     6076           
  Branches      759      759           
=======================================
  Hits         5488     5488           
  Misses        466      466           
  Partials      122      122           
Flag Coverage Δ
query_engine 86.83% <ø> (ø)
reporting 94.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tombonfert
tombonfert merged commit 507bead into main Nov 12, 2026
10 checks passed
@tombonfert
tombonfert deleted the feature/app_increase_max_rounds_default branch November 12, 2026 09:07

This branch was previously deployed

1 inactive deployment
e2e — f4c5b21d Deployed Nov 12, 2026 by tombonfert via Remove the PR's e2e bundle #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants