Repository navigation
Conversation
Signed-off-by: Shubham Dhal <shubham.dhal@databricks.com>
sd-db
marked this pull request as ready for review
November 17, 2026 16:00
sd-db
enabled auto-merge (squash)
November 17, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On a runner without cached Python 3.10,
setup-pythonreinstalls pip. Thegather-shardsjobs did not configure a package source first, so pip attempted blocked public PyPI and the jobs failed before downloading artifacts or verifying shard coverage, even when all functional shards passed.Both integration workflows now restore the existing Python dependency cache before Python setup and configure the existing JFrog proxy fallback on a cache miss. Cache hits use the offline wheelhouse. Artifact handling and shard-verification behavior are unchanged.
Validation: 18 focused local bootstrap/verifier checks, five existing workflow regression tests, full code-quality checks, and an offline pip reinstall in a fresh Python 3.10 environment passed. The verifier checks execute both workflows' shell commands against valid artifacts and reject wrong test IDs or missing JUnit files for all three profiles. Cache-miss configuration was simulated; actual runner cache restoration and JFrog authentication remain to be verified in GitHub Actions.
Checklist
dbt-databricks-pr-readyproject skill for this PR and addressed its merge-readiness feedback.