Repository navigation
fix: retry Thrift requests on the same statuses and network errors as the kernel #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vuanhphung
wants to merge
15
commits into
main
Choose a base branch
from
fix/thrift-retry-open-session-and-rejected-execute
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a9a6052
fix: retry Thrift OpenSession and a 503-with-Retry-After ExecuteState…
vuanhphung c6b3606
fix: wait as long as Retry-After asks, except for the feature-flag fetch
vuanhphung ab623a9
fix: retry the same statuses and network errors as the kernel backend
vuanhphung b3b240d
fix: keep "Request timed out" when every retried attempt times out
vuanhphung 111ee19
test: pin "Request timed out" when the first timeout uses up the budget
vuanhphung be73bde
fix: keep the feature-flag fetch's retries, without stretching connect()
vuanhphung 26abeb4
fix: cap the feature-flag fetch's total time, and retry a multi-addre…
vuanhphung fa5e6e4
refactor: rename UnsentRequestRetryPolicy to NonIdempotentRequestRetr…
vuanhphung 7ae6980
fix: keep the original error once retries this PR adds run out
vuanhphung 2a3aac7
fix: don't retry certificate failures Node reports as UNSPECIFIED
vuanhphung dd04e5f
docs: shorten the retry CHANGELOG entry and merge the ExecuteStatemen…
vuanhphung 9ac4ae0
docs: say that certificate and ENOTFOUND failures now throw FetchError
vuanhphung 90e2eb2
fix: keep main's RetryError for an idempotent RPC on a status below 100
vuanhphung ec099fd
docs: simplify the retry CHANGELOG entry
vuanhphung 271d2d5
docs: say CloudFetch downloads fail with RetryError once retries run out
vuanhphung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.