Skip to content

ci(bot): enable distillation and cross-review - #575

Merged
vuanhphung merged 2 commits into
mainfrom
vu/bot-learning-cross-review
Nov 17, 2026
Merged

vuanhphung merged 2 commits into
mainfrom
vu/bot-learning-cross-review

Conversation

@vuanhphung

@vuanhphung vuanhphung commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Apply kernel #476's onboarding: enable distill mode with learning-PR auto-merge off, and pin the bot engine to 6014478 for two independent reviewers plus a judge. Manual reviews use trusted workflow code and a separate resolved PR checkout.

Preserve all 84 rules from #443 at 82969ff as a frozen archive and seed 59 lessons. New learning uses dated journal files and a fresh rolling branch. Unignore lessons and journal Markdown so learning commits can track them.

98 focused engine tests passed. Config, archive preservation, lesson routing/source checks, seven reviewer-input cases, Bash syntax and actionlint passed. Live cross-review approved the current head; source-format nit explained.

After merge, run learning once and inspect its first journal/lessons PR. Check #443 for newer entries before retiring that legacy PR.

Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Terra), checked by a judge model (Claude Sonnet 5.5).

✅ No issues identified.

Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Terra), checked by a judge model (Claude Sonnet 5.5).

Verdict: 1 Nit

Looks good, no blocking issues. The reviewer workflow now checks out trusted code at the base SHA, and the PR head is checked out separately after an open, same-repo PR check. The archive, lessons and .gitignore routing all look consistent. Follow-up: review-content is a shallow checkout, so confirm the pinned engine doesn't need PR_BASE_SHA history inside it.

This overview is Claude Opus 5.5's initial take; some of its points were set aside by the cross-check judge — see the findings below.

Other findings

  • ⚪ Nit — L-0059 claims 4× occurrences but cites only log:2026-10-21. The matching archive entries from 2026-10-22, 2026-10-30 and 2026-11-12 aren't listed, so the count can't be traced. Add those log dates as sources. (Found by Claude Opus 5.5 · confirmed by the judge)
🔀 1 finding considered and dismissed by the judge
  • 🟡 Medium .github/workflows/reviewer-bot.yml:64 — For manual dispatches, github.sha is the selected dispatch ref, so choosing a PR branch loads its local prelude with App credentials instead of trusted defaul
    Judge's evidence: ref: ${{ github.event.pull_request.base.sha || github.sha }}

@vuanhphung

Copy link
Copy Markdown
Collaborator Author

Keeping the supported source format for L-0059: the engine grammar allows one log:YYYY-MM-DD, so adding four log dates would make this file invalid. Its 4× count is four archived observations, preserved under 2026-10-21 (run #39539859873), 2026-10-22 (#39665654097), 2026-10-30 (#40976127852), and 2026-11-12 (#43090396242). The source field is a representative reference; the frozen archive retains the full evidence. Also confirmed the shallow review checkout is sufficient: run_review.py fetches diffs through GitHub's compare API; local base history is not required.

@vuanhphung
vuanhphung marked this pull request as ready for review November 17, 2026 22:50

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@vuanhphung
vuanhphung enabled auto-merge November 17, 2026 23:04
@vuanhphung
vuanhphung added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit d9008a9 Nov 17, 2026
16 checks passed
@vuanhphung
vuanhphung deleted the vu/bot-learning-cross-review branch November 17, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant