Skip to content

[coverage] Conformance findings: AUTH-017,AUTH-018 #540

Closed

Description

@peco-engineer-bot

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.

Findings

  • AUTH-017 [thrift]: Thrift backend retries an unrecoverable server-certificate chain-of-trust failure: the untrusted-CA refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff) instead of failing fast on the first attempt
    • failing test: TestTLSRejectsUntrustedServerCertificate (see the coverage PR diff under tests/)
  • AUTH-018 [thrift]: Thrift backend retries an unrecoverable server-certificate hostname mismatch: the refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff) instead of failing fast on the first attempt
    • failing test: TestTLSRejectsServerCertificateHostnameMismatch (see the coverage PR diff under tests/)
  • AUTH-017: Thrift backend retries an unrecoverable server-certificate chain-of-trust failure: the untrusted-CA refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff, "request error after 5 attempt(s)") instead of failing fast on the first attempt; the kernel backend fails fast correctly
  • AUTH-018: Thrift backend retries an unrecoverable server-certificate hostname mismatch: the refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff) instead of failing fast on the first attempt; TLS certificate errors need classifying as non-retryable in the retry policy

Reproduce & Expected

AUTH-017 — Verifies that the driver refuses a server certificate that does not chain to a trusted root, that the refusal is TERMINAL (the certificate failure is not retried), and that the error NAMES the certif…

Expected (per the shared spec):

  • full assertion contract:
result:
- label: unknown_ca
  error:
    contains:
    - certificate
    - cert
    - x509
    - pkix
    - ssl
    - tls
    - trust
    - verify
    - issuer
    - handshake
- label: unknown_ca
  server_received_request: false
- label: unknown_ca
  server_observed_connection_attempts: 1
- label: self_signed_with_custom_ca
  error:
    contains:
    - certificate
    - cert
    - x509
    - pkix
    - ssl
    - tls
    - trust
    - verify
    - issuer
    - self signed
    - self-signed
    - handshake
- label: self_signed_with_custom_ca
  server_received_request: false
- label: trusted_ca
  tls_handshake_completed: true
- label: trusted_ca
  server_received_request: true

AUTH-018 — Verifies that the driver checks the server certificate's subject alternative names against the endpoint it connects to: a certificate issued by a trusted CA for a different host is refused, the refus…

Expected (per the shared spec):

  • full assertion contract:
result:
- label: hostname_mismatch
  error:
    contains:
    - hostname
    - host name
    - altname
    - subject alternative
    - not valid for
    - mismatch
    - match
    - certificate
    - cert
    - x509
    - pkix
    - ssl
    - tls
    - verify
    - handshake
- label: hostname_mismatch
  server_received_request: false
- label: hostname_mismatch
  server_observed_connection_attempts: 1
- label: hostname_match
  tls_handshake_completed: true
- label: hostname_match
  server_received_request: true

Context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions