Repository navigation
Closed
Description
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.
Findings
- AUTH-017 [thrift]: Thrift backend retries an unrecoverable server-certificate chain-of-trust failure: the untrusted-CA refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff) instead of failing fast on the first attempt
- failing test:
TestTLSRejectsUntrustedServerCertificate(see the coverage PR diff undertests/)
- failing test:
- AUTH-018 [thrift]: Thrift backend retries an unrecoverable server-certificate hostname mismatch: the refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff) instead of failing fast on the first attempt
- failing test:
TestTLSRejectsServerCertificateHostnameMismatch(see the coverage PR diff undertests/)
- failing test:
- AUTH-017: Thrift backend retries an unrecoverable server-certificate chain-of-trust failure: the untrusted-CA refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff, "request error after 5 attempt(s)") instead of failing fast on the first attempt; the kernel backend fails fast correctly
- AUTH-018: Thrift backend retries an unrecoverable server-certificate hostname mismatch: the refusal re-dials for the full default RetryMax budget (5 connections, ~15s backoff) instead of failing fast on the first attempt; TLS certificate errors need classifying as non-retryable in the retry policy
Reproduce & Expected
AUTH-017 — Verifies that the driver refuses a server certificate that does not chain to a trusted root, that the refusal is TERMINAL (the certificate failure is not retried), and that the error NAMES the certif…
Expected (per the shared spec):
- full assertion contract:
result:
- label: unknown_ca
error:
contains:
- certificate
- cert
- x509
- pkix
- ssl
- tls
- trust
- verify
- issuer
- handshake
- label: unknown_ca
server_received_request: false
- label: unknown_ca
server_observed_connection_attempts: 1
- label: self_signed_with_custom_ca
error:
contains:
- certificate
- cert
- x509
- pkix
- ssl
- tls
- trust
- verify
- issuer
- self signed
- self-signed
- handshake
- label: self_signed_with_custom_ca
server_received_request: false
- label: trusted_ca
tls_handshake_completed: true
- label: trusted_ca
server_received_request: trueAUTH-018 — Verifies that the driver checks the server certificate's subject alternative names against the endpoint it connects to: a certificate issued by a trusted CA for a different host is refused, the refus…
Expected (per the shared spec):
- full assertion contract:
result:
- label: hostname_mismatch
error:
contains:
- hostname
- host name
- altname
- subject alternative
- not valid for
- mismatch
- match
- certificate
- cert
- x509
- pkix
- ssl
- tls
- verify
- handshake
- label: hostname_mismatch
server_received_request: false
- label: hostname_mismatch
server_observed_connection_attempts: 1
- label: hostname_match
tls_handshake_completed: true
- label: hostname_match
server_received_request: trueContext
- The behavior was first fixed in a DIFFERENT driver — reference PR: fix: update kernel pin for TLS certificate errors databricks-sql-nodejs#576 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-go; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1980
Metadata
Metadata
Assignees
Labels
No labels
Activity