Repository navigation
fix(ui): drop deprecated site info fetch and reload doc on query change - #60
Merged
Merged
Conversation
… urls
createSession({ siteInfo: true }) fetched _public at startup and logged
'refreshSiteInfo is deprecated'. index.html now loads the hashed _theme.css
and _public.js filled by createSpaMiddleware (privateDirectoryUrl), as in
catalogs and processings. The tags are injected through SITE_RESOURCES,
empty in standalone mode (useSimpleDirectory: false).
Since Vue Router 5 route.query is not reactive, so watch(route.query) was an invalid source and the doc was never refetched after an in-app query change (e.g. a d-frame parent switching dataset). Watch the resolved doc url instead, so operation/params changes still do not refetch it. Also make home externalDocs and servers props optional, both are optional in OpenAPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the console warnings seen on staging, keeping the standalone mode working.
index.htmlloads the hashed_theme.cssand_public.jsfrom simple-directory (filled bycreateSpaMiddlewarewithprivateDirectoryUrl, as in catalogs and processings), andcreateSessionno longer usessiteInfo: true, which loggedrefreshSiteInfo is deprecated. The tags are injected through a{SITE_RESOURCES}template param, empty in standalone mode (useSimpleDirectory: false).watch(route.query)was an invalid source and only ran once. The resolved doc URL is watched instead, so operation/params changes still do not refetch the doc.externalDocsandserversprops ofhome.vueare optional, as in OpenAPI.Heads-up: each
index.htmlrequest now asks simple-directory for the site hashes (cached 1 min) atPRIVATE_DIRECTORY_URL, which was already required for the session.