Repository navigation
chore: smoother dev workflow, release script and package READMEs - #62
Merged
Merged
Conversation
skills/ is the source; .agents/skills, .claude/skills and skills-lock.json were stale local installs (pr-ready, skill-creator).
A fresh checkout, or a new file imported by build.ts, failed with ERR_MODULE_NOT_FOUND until a manual build-tsc bootstrap.
quality = build + lint + test: tests import the built .js, so build first. lint no longer fixes files. site.test.js was never run, now site.test.ts. engines >=22.6 for --experimental-strip-types.
The root README documented removed APIs (initSession, colors.js, Nuxt module, stringify export, old @data-fair/lib paths). Its still valid content moved to the package READMEs, verified against the sources; npm pages were empty.
common-types, node, processing-dev, utils and vue declared main: index.js but ship no index, so a bare import failed with a misleading error.
tsc never removes them and npm publish ships every **/*.js: a deleted module (e.g. lib-vue selection-filters) would have been published again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the lib easier to build, test, release and read, separately from the dev-env work.
Build
build-typescompiles the generator's own imports: a fresh checkout, or a new file imported bybuild.ts, no longer fails withERR_MODULE_NOT_FOUND(the manualbuild-tscbootstrap is gone from CONTRIBUTING).build-tscremoves the build outputs whose source was deleted (scripts/clean-orphans.mts): tsc never does it andnpm publishships every**/*.js, so a deleted module (e.g. lib-vueselection-filters) would have been published again.buildno longer runseslint --fix.Hooks and CI
commit-msgpasses"$1".quality= build + lint + test, in that order: tests import the built.js, the old pre-push tested a possibly stale build. Used by pre-push,prepublishOnlyand the new pull request workflow.lintno longer fixes files (fixes made at commit time were not staged);lint-fixdoes.site.test.jswas never run (the glob only takes.ts): nowsite.test.ts.engines>=22.6, needed by--experimental-strip-types.Release
npm run release <package> <patch|minor|major>bumps the version and creates thechore: release lib-<name> <version>commit (package.json + lockfile), thengit pushandnpm publish -w packages/<package>as before. A plain npmversionhook cannot do it: npm updates the lockfile after its version hooks.Docs
initSession,colors.js, Nuxt module,stringifyexport, old@data-fair/lib/...paths).upgrade-scriptsskill:locks.start(db), notlocks.init(db). lib-vuetify description: Vuetify 4.Fixes
main: index.jsfrom the packages without a root entry (common-types, node, processing-dev, utils, vue).lib-*packages.Cleanup
.agents/,.claude/skills/,skills-lock.json);skills/is the source..gitignore:.superpowers/,.claude/settings.local.json.Not included:
debug(lib-node, lib-express, lib-vue) andprom-client(lib-express) are imported without being declared as dependencies.