Skip to content

fix: let release reruns find build payloads from an earlier attempt - #399

Merged
arzafran merged 1 commit into
mainfrom
fix/release-rerun-artifacts
Oct 2, 2026
Merged

arzafran merged 1 commit into
mainfrom
fix/release-rerun-artifacts

Conversation

@arzafran

@arzafran arzafran commented Oct 1, 2026

Copy link
Copy Markdown
Member

What this does

Makes "Re-run failed jobs" work on the release workflow. Today it can never succeed after a partial failure.

Each build job uploaded its payload under a name that included the run attempt, and assemble-release downloaded using its own attempt number. When only the failed jobs rerun, a build that passed in attempt 1 keeps its -1 artifact, while assembly in attempt 2 asks for -2. That happened on run 36914378110: macOS signing failed in attempt 1, the rerun signed fine, and assembly failed with Artifact not found for name: programa-windows-36914378110-2.

Now the payload names are per run, and the uploads set overwrite: true so a rebuilt job in a later attempt replaces its earlier payload.

Test plan

  • The next main release run publishes to rolling as before.
  • Next time a release partially fails, "Re-run failed jobs" reaches promote-rolling without a full rerun.

@arzafran
arzafran merged commit dc3fa59 into main Oct 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant