fix: let release reruns find build payloads from an earlier attempt - #399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Makes "Re-run failed jobs" work on the release workflow. Today it can never succeed after a partial failure.
Each build job uploaded its payload under a name that included the run attempt, and
assemble-releasedownloaded using its own attempt number. When only the failed jobs rerun, a build that passed in attempt 1 keeps its-1artifact, while assembly in attempt 2 asks for-2. That happened on run 36914378110: macOS signing failed in attempt 1, the rerun signed fine, and assembly failed withArtifact not found for name: programa-windows-36914378110-2.Now the payload names are per run, and the uploads set
overwrite: trueso a rebuilt job in a later attempt replaces its earlier payload.Test plan
rollingas before.promote-rollingwithout a full rerun.