Fix get_state_names omitting untouched initstate keys in MockStateManager - #1216
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
…ager Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MockStateManager.get_state_names()only looked at_default_state_change_tracker, which stays empty for any state key that was seeded viainitstateand never explicitly read or written during the current test.contains_state()right next to it already falls back to_mock_state(the dictMockActor's own docstring shows users asserting against directly), so the two methods disagreed:contains_state('balance')returnedTruefor a seeded key whileget_state_names()silently omitted it.Since every mutating method (
try_add_state,set_state_ttl,try_remove_state,get_or_add_state,add_or_update_state) already keeps_mock_statein sync,get_state_names()now just returnslist(self._mock_state.keys()).Issue reference
Please reference the issue this PR will close: N/A, self-discovered while testing actor state mocking, no existing issue filed.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: