Skip to content

Fix get_state_names omitting untouched initstate keys in MockStateManager - #1216

Open
magic-peach wants to merge 1 commit into
dapr:mainfrom
magic-peach:fix/mock-state-manager-get-state-names-initstate
Open

magic-peach wants to merge 1 commit into
dapr:mainfrom
magic-peach:fix/mock-state-manager-get-state-names-initstate

Conversation

@magic-peach

Copy link
Copy Markdown
Contributor

Description

MockStateManager.get_state_names() only looked at _default_state_change_tracker, which stays empty for any state key that was seeded via initstate and never explicitly read or written during the current test. contains_state() right next to it already falls back to _mock_state (the dict MockActor's own docstring shows users asserting against directly), so the two methods disagreed: contains_state('balance') returned True for a seeded key while get_state_names() silently omitted it.

Since every mutating method (try_add_state, set_state_ttl, try_remove_state, get_or_add_state, add_or_update_state) already keeps _mock_state in sync, get_state_names() now just returns list(self._mock_state.keys()).

Issue reference

Please reference the issue this PR will close: N/A, self-discovered while testing actor state mocking, no existing issue filed.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…ager

Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
@magic-peach
magic-peach requested review from a team as code owners September 16, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant