[cyberjunky]

Builds on #478, which keeps the tests offline.

The mobile login strategies have answered 429 on every attempt, and it isn't a rate limit. Since the April rewrite (5-strategy chain), _do_mobile_login posts the credentials straight to /mobile/api/login without first loading the sign-in page. The original implementation, and the iOS app's web view, load /mobile/sso/en_US/sign-in first.

Tested live in the same minute, with the same fingerprint (safari_ios) and a made-up account:

Request	Result
current code: direct POST	429
load the sign-in page	200, sets SESSION, __cf_bm, __cflb, …
then POST with those cookies and the page as Referer	401 INVALID_USERNAME_PASSWORD, i.e. the request was processed

Change

• _do_mobile_login loads the sign-in page first, waits 2–5 s (MOBILE_DELAY_MIN_S/MAX_S), then posts with Referer and Accept-Language.
• A block on the page load (427/429, or a 403 challenge) stops before any credentials are sent.

Tests

• New tests/test_mobile_login.py: the page load happens before the POST, the POST carries the Referer and Accept-Language, and a blocked or challenged page load sends nothing. All 4 fail without the change.
• The existing mobile test's fake session gained a get().
• The full suite passes (637) with zero network connections. Ruff and mypy are clean.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Source mode: Auto
• Repository: cyberjunky/python-garminconnect
• Branch: fix/mobile-login-signin-page
• File: .coderabbit.yaml
• Commit: c635074
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: b7053a2c-374d-4bc2-bd65-aff621ea4701

📥 Commits

Reviewing files that changed from the base of the PR and between 3251a6f and c635074.

📒 Files selected for processing: 5

• CHANGELOG.md
• garminconnect/client/constants.py
• garminconnect/client/sso.py
• tests/test_garmin_unit.py
• tests/test_mobile_login.py

+------------------------------------------+
| My GPUs are ready. Let's find some bugs. |
+------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}