fix(pstack): accept PRs without checks

[liush2yuxjtu]

Why

watch-pr --status-only retries forever when a mergeable pull request has no configured checks. gh pr checks reports that no checks exist, and the GraphQL rollup is empty, but resolveChecks treats every empty result as a query failure.

Scope

• Adds failing coverage for empty fast-path and GraphQL check results.
• Lets CheckRead.checks and CiBase.all represent a valid empty check set.
• Accepts empty checks only when the fast path returns valid empty JSON or gh returns its exact no-checks message, and the GraphQL rollup is also empty.
• Preserves fail-closed behavior for credential and unrelated exit-1 errors.

Tradeoffs

The no-checks detection depends on the current gh stderr message. If gh changes that text, the watcher fails closed and reports a query blocker instead of treating an error as clean CI.

Blast Radius

The change affects PRs with zero checks. PRs with passing, pending, failed, or hidden GitHub rollups keep the existing paths. No plugin prompt or workflow text changes.

Verification

Before the fix, three focused tests failed with ChecksUnavailable.

After the fix:

• bun test watch-pr passed 42 tests.
• bun run typecheck passed.
• A live watch-pr --status-only run against liush2yuxjtu/pi-debug-mode#2 returned a status table instead of RETRY before a later GitHub API TLS timeout made the external check unavailable.
• git diff --check passed.

---

Note

Medium Risk
Behavior for zero-check PRs and new heads after prior CI changed; empty detection depends on a fixed gh stderr string, so a message change would fail closed rather than silently mark CI clean.

Overview
Fixes watch-pr --status-only looping on mergeable PRs that have no CI checks: when both gh pr checks and the GraphQL rollup are empty, the watcher now treats that as a valid empty check set instead of raising ChecksUnavailable.

resolveChecks returns an empty list only if the fast path is valid empty JSON or exit code 1 with GitHub’s exact “no checks reported on the … branch” stderr and the rollup paginates to zero checks; unrelated exit-1 errors (e.g. integration access) still fail closed. CheckRead.checks and snapshot ci.all are typed as ordinary arrays so ci-clean can carry [].

readSnapshot adds a guard: if the head has no checks but an older commit had passing rollup CI, it throws ChecksUnavailable so a fresh push is waited on rather than marked clean. New tests cover empty-check acceptance, unrelated fast-path failures, no-check PR classification, and the post-push wait case.

^{Reviewed by Cursor Bugbot for commit 09591fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Stale Bugbot comment from a previous run.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.}

^{Reviewed by Cursor Bugbot for commit 09591fc. Configure here.}

[cursor]

Prior SUCCESS fail-closes empty checks

Medium Severity · Logic Bug

readSnapshot throws ChecksUnavailable for a confirmed-empty check list whenever any non-head commit rollup is SUCCESS. Settled heads with no runs after skipped or path-filtered workflows match that predicate, so pollUntilTerminal retries and then emits a status-query BLOCKER instead of ci-clean. --status-only never prints a table.

 

^{Reviewed by Cursor Bugbot for commit 09591fc. Configure here.}

[liush2yuxjtu]

关闭此 PR。修复和测试已保留在分支 fix/watch-pr-zero-checks；如需继续合并，可重新打开或创建新 PR。