Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
caleb-bit
requested changes
Oct 28, 2026
caleb-bit
left a comment
caleb-bit
left a comment
There was a problem hiding this comment.
Mostly looks good, left a few comments.
|
|
||
| BackHandler(enabled = editingPicture) { editingPicture = false } | ||
| var editingSports by rememberSaveable { mutableStateOf(false) } | ||
| var favorites by rememberSaveable(data.favorites, stateSaver = listSaver<List<ProfileFavorite>, String>( |
There was a problem hiding this comment.
remove redundant explicit type argument
| val options = (favorites + favoriteSportOptions).distinct() | ||
| .filter { gender == GenderDivision.ALL || it.gender == gender } | ||
| .sortedWith(compareBy<ProfileFavorite> { it !in favorites } | ||
| .thenBy { it.sport.displayName }.thenBy { it.gender == GenderDivision.FEMALE }) |
There was a problem hiding this comment.
Can we extract this compareBy logic?
| .fillMaxWidth().border(1.dp, GrayLight, CircleShape) | ||
| .padding(6.dp).selectableGroup() | ||
| ) { | ||
| listOf(GenderDivision.ALL, GenderDivision.MALE, GenderDivision.FEMALE).forEach { division -> |
There was a problem hiding this comment.
Can we just use GenderDivision.entries?
| Box(Modifier.fillMaxWidth().aspectRatio(1f), contentAlignment = Alignment.Center) { | ||
| Box( | ||
| Modifier.fillMaxSize() | ||
| .background(if (selected) Color(0xFFF6FFF3) else GrayStroke, shape) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #120; targets
populated-profile.The Favorite Sports Edit button opens a three-column selector with All/Men’s/Women’s filters. Selected sports appear first with green borders and remove badges. Tapping a sport adds or removes that division, and going back updates the profile favorites.