Repository navigation
Define model architecture and weights - #94
Open
Zain-Mahmoud wants to merge 14 commits into
Open
Zain-Mahmoud wants to merge 14 commits into
Zain-Mahmoud wants to merge 14 commits into
Conversation
Coverage Report for CI Build 38022721650Coverage decreased (-26.1%) to 72.481%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Contributor
Author
|
/test all |
|
Tests passed
|
Contributor
Author
|
/test gpu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to import the model architecture from the original terrain-diffusion repo, and loads the weights for those models. The model architecture is defined under
models/and is connected to the inference interface to be used the model pipeline.The inference models here are wrappers around the inference models from the original repo and share the same interface as the mock models we created earlier. The purpose of this interface is to abstract away the actual ML implementation from the final pipeline. These models will all be used in the model pipeline where the outputs will be connected to each other.
Validation
scripts/quality-check.shpasses locally/testcommands were run and are passing (e.g./test gpu)Checklist
Additional Comments
I ran the GPU tests in a Google colab notebook and they seemed to be working fine.