You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clicking Send for a saved font threw ReferenceError: family is not defined before the upload job started, so no font data reached the reader. The failure-message argument now uses font.family, which is in scope when the handler runs.
Adds regression tests that click Send and verify the multipart upload's family, filename, and bytes, plus success and upload-failure feedback.
Validation:
App suite: 429 tests passed across 32 files.
Regression tests reproduced the ReferenceError before the fix.
macOS release app built successfully; font sending confirmed on a real reader.
iPhone 16 Pro: font sending confirmed successful on a physical device with the organization-signed build. Transfer was slow, but completed successfully.
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.
No actionable comments were generated in the recent review.
Walkthrough
The send failure message now uses font.family. A new test checks the uploaded font data and the success and failure notifications.
Changes: Reader font upload
Layer / File(s)
Summary
Send and verify font upload app/src/ReaderFonts.jsx, app/src/ReaderFonts.test.jsx
The failure message uses font.family. The test checks the POST payload, success notification, and failure notification with the reader’s response text.
This fixes the error that stopped saved fonts from being sent to a reader and adds regression tests. No actionable merge risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: fixing font sending so it works before the upload starts. The raw summary and objectives both describe a fix that changes the failure-message argument to font.family, …
Description check
The description states the bug (ReferenceError: family is not defined when clicking Send), the fix (use font.family in the failure-message argument), the added regression tests, and validation steps. …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: fixing font sending so it works before the upload starts. The raw summary and objectives both describe a fix that changes the failure-message argument to font.family, which resolves the ReferenceError. The title is specific and accurate.
Full details: Description check
Explanation
The description states the bug (ReferenceError: family is not defined when clicking Send), the fix (use font.family in the failure-message argument), the added regression tests, and validation steps. These match the raw summary of ReaderFonts.jsx and ReaderFonts.test.jsx.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 0947694b-a160-4375-b3a6-5e29a65e8e56
Commits
Reviewing files that changed from the base of the PR and between 1e1294e and fcfe4e9.
Files selected for processing: 2
app/src/ReaderFonts.jsx
app/src/ReaderFonts.test.jsx
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking Send for a saved font threw
ReferenceError: family is not definedbefore the upload job started, so no font data reached the reader. The failure-message argument now usesfont.family, which is in scope when the handler runs.Adds regression tests that click Send and verify the multipart upload's family, filename, and bytes, plus success and upload-failure feedback.
Validation: