Skip to content

chore: allow pre-installed dev tools (for nix) - #715

Merged
creativeprojects merged 1 commit into
masterfrom
allow-pre-installed-dev-tools
Nov 15, 2026
Merged

creativeprojects merged 1 commit into
masterfrom
allow-pre-installed-dev-tools

Conversation

@creativeprojects

Copy link
Copy Markdown
Owner

Allow pre-installed dev tools
Don't enforce the use of aqua in the Makefile as it's likely to break the nix builds

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Makefile targets now use tools available on PATH and install missing tools with aqua. CONTRIBUTING.md describes aqua as optional and documents the updated tool requirements.

Changes

Tool resolution

Layer / File(s) Summary
PATH-first tool resolution and target updates
Makefile, CONTRIBUTING.md
The Makefile checks for tools on PATH before using aqua to install missing tools. Mock, test, release, documentation, lint, link-check and Docker targets use the new tool targets. CONTRIBUTING.md describes aqua as optional and notes that manually managed tool versions may differ from CI.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 3fcc0

The Makefile now uses tools already on PATH and falls back to aqua only when a tool is missing, which allows Nix-style pre-installed tools. No concrete merge-blocking risk was found. Manually installed tool versions are not pinned and may differ from CI, and CONTRIBUTING.md documents this.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the Makefile and contributing guide now accept dev tools already on PATH instead of requiring aqua. It uses the conventional chore: prefix and gives the Nix motivation…
Description check Passed The description states the purpose of the change: stop the Makefile from enforcing aqua, which could break Nix builds. This matches the Makefile and CONTRIBUTING.md changes described in the summary.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the Makefile and contributing guide now accept dev tools already on PATH instead of requiring aqua. It uses the conventional chore: prefix and gives the Nix motivation. It is concise and specific enough for a teammate scanning history.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: be2c86ee-d37a-4357-889f-d6a63cb44027
Commits

Reviewing files that changed from the base of the PR and between 54297ff and 3fcc009.

Files selected for processing: 2

  • CONTRIBUTING.md
  • Makefile

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.41%. Comparing base (c6670cb) to head (3fcc009).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files         161      161           
  Lines       10336    10336           
=======================================
  Hits         8828     8828           
  Misses       1508     1508           
Flag Coverage Δ
unittests 83.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@creativeprojects
creativeprojects merged commit 17f0a48 into master Nov 15, 2026
19 of 20 checks passed
@creativeprojects
creativeprojects deleted the allow-pre-installed-dev-tools branch November 15, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant