[5.x] Deleted rules removing unrelated catalog prices - #4375
Merged
nfourtythree merged 2 commits intoSep 28, 2026
Merged
nfourtythree merged 2 commits into
nfourtythree merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Queue cleanup failures can leave jobs permanently reserved; move the cleanup into the protected error-handling block.
Review effort: Lite
Findings: None
What changed in this PR
Fixes catalog pricing regeneration when queued rules are deleted, preventing unrelated prices from being removed.
Changes:
- Treats empty rule sets as a no-op.
- Cleans up stale queue entries.
- Adds regression tests and changelog documentation.
| File | Summary |
|---|---|
tests/unit/services/CatalogPricingTest.php |
Adds regression coverage. |
src/services/CatalogPricing.php |
Prevents regeneration for empty rule selections. |
src/queue/jobs/CatalogPricing.php |
Handles deleted rules in queued jobs. |
CHANGELOG.md |
Documents the fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nfourtythree
deleted the
nathaniel/com-683-5x-catalog-pricing-job-wipes-every-rules-prices-when-its
branch
September 28, 2026 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#4374