Repository navigation
Conversation
Owner
|
The appropriate way to handle a UTF-8 BOM is to open the file with |
Author
|
Thanks for clarifying the intended behavior. Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a UTF-8 BOM-prefixed
.gitignorewithencoding="utf-8"leaves the BOM in the first pattern. For example:Git skips one UTF-8 BOM at the start of an ignore file before parsing its lines (implementation in Git 2.54.0). Strip it at the
GitIgnoreSpec.from_lines()boundary, where the first line can be distinguished from later patterns. Comments, negations and anchored directory rules then retain their meaning. A second BOM or a BOM on a later line remains literal. Both text and byte lines are supported, including single-pass iterators and the reversed argument form.Added regression and control tests, a docstring note and a changelog entry.
Validation on Windows:
py312andpy314: the full base suite succeeds on CPython 3.12.14 and 3.14.5, with optional backend/platform skips.python -m unittest discover -t . -s tests/on CPython 3.14.5 runs all 300 tests successfully, without skips.mypy pathspec tests/check_usage.pypasses for all 32 source files.git check-ignore --no-index --verbose --non-matching -zusing Git 2.54.0.windows.1.git diff --checkpasses.