docs(platform-package): add publishing.serviceDomain - #724
Merged
Merged
Conversation
Aleksei Sviridkin (lexfrei)
requested review from
Andrei Kvapil (kvaps),
Timofei Larkin (lllamnyp),
myasnikovdaniil and
Timur Tukaev (tym83)
as code owners
September 30, 2026 18:47
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
IvanHunters
approved these changes
Oct 5, 2026
IvanHunters
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Accurate row for the new platform value. I checked it against the merged cozystack/cozystack#4035 and the live source on main rather than against the PR description.
What I confirmed:
publishing.serviceDomainexists with default""inpackages/core/platform/values.yamlon main, and the row text is a verbatim copy of that file's comment (only "e.g." expanded to "for example").- The dashboard behaviour matches the code:
ServicesTab.tsxbuilds${svc.metadata.name}.${serviceDomain}for LoadBalancer services only,config.tscarriesserviceDomain, andapps.yamlwires it through the cozystack-values Secret. - The example
demo-external-write.svc.example.orgis right:packages/apps/postgres/templates/external-svc.yamlnames the LoadBalancer Service{{ .Release.Name }}-external-write. - Scoping it to
nextonly is correct. The key is in no released version (it merged after v1.6.4 and v1.7.0-alpha.3), and the site has no v1.7 tree yet. - Table stays intact: the publishing table is three columns (Value | Default | Description), the new row matches, and there are no stray pipes in the cell.
Two optional nits, neither blocking:
- [NIT] The row sits after the dns01 certificate block, but in
values.yamlserviceDomainfollowsloadBalancerClass, and both are about LoadBalancer-service publishing, so sitting next toloadBalancerClasswould mirror the source grouping. Cosmetic only. - [NIT] The cell is a dense paragraph, but it is copied verbatim from
values.yamland reads the same as the neighbouringloadBalancerClass/ingressNameAdminrows, so it is consistent with the file.
IvanHunters
enabled auto-merge
October 5, 2026 11:43
Aleksei Sviridkin (lexfrei)
force-pushed
the
docs/publishing-service-domain
branch
from
October 5, 2026 12:22
73b90ed to
c036e4a
Compare
Document the platform value that sets the DNS suffix the dashboard shows under the external IP of LoadBalancer Services. Only the next trunk carries it: no released version has the key yet. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
Aleksei Sviridkin (lexfrei)
force-pushed
the
docs/publishing-service-domain
branch
from
October 5, 2026 12:27
c036e4a to
c842929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the new platform value
publishing.serviceDomainin the publishing table of the platform-package reference. The value was added in cozystack/cozystack#4035.Only
nextgets the row. No released version has the key yet, sov1.6stays as is. The description is taken from the values.yaml comment on main.