Skip to content

docs(platform-package): add publishing.serviceDomain - #724

Merged
IvanHunters merged 1 commit into
mainfrom
docs/publishing-service-domain
Oct 5, 2026
Merged

IvanHunters merged 1 commit into
mainfrom
docs/publishing-service-domain

Conversation

@lexfrei

Copy link
Copy Markdown
Contributor

This documents the new platform value publishing.serviceDomain in the publishing table of the platform-package reference. The value was added in cozystack/cozystack#4035.

Only next gets the row. No released version has the key yet, so v1.6 stays as is. The description is taken from the values.yaml comment on main.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 266de98b-f610-478a-afd8-5689b7900891
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cozystack ready!

Name Link
🔨 Latest commit c842929
🔍 Latest deploy log https://app.netlify.com/projects/cozystack/deploys/6ac397bba229ab0008677593
😎 Deploy Preview https://deploy-preview-724--cozystack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@IvanHunters IvanHunters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Accurate row for the new platform value. I checked it against the merged cozystack/cozystack#4035 and the live source on main rather than against the PR description.

What I confirmed:

  • publishing.serviceDomain exists with default "" in packages/core/platform/values.yaml on main, and the row text is a verbatim copy of that file's comment (only "e.g." expanded to "for example").
  • The dashboard behaviour matches the code: ServicesTab.tsx builds ${svc.metadata.name}.${serviceDomain} for LoadBalancer services only, config.ts carries serviceDomain, and apps.yaml wires it through the cozystack-values Secret.
  • The example demo-external-write.svc.example.org is right: packages/apps/postgres/templates/external-svc.yaml names the LoadBalancer Service {{ .Release.Name }}-external-write.
  • Scoping it to next only is correct. The key is in no released version (it merged after v1.6.4 and v1.7.0-alpha.3), and the site has no v1.7 tree yet.
  • Table stays intact: the publishing table is three columns (Value | Default | Description), the new row matches, and there are no stray pipes in the cell.

Two optional nits, neither blocking:

  • [NIT] The row sits after the dns01 certificate block, but in values.yaml serviceDomain follows loadBalancerClass, and both are about LoadBalancer-service publishing, so sitting next to loadBalancerClass would mirror the source grouping. Cosmetic only.
  • [NIT] The cell is a dense paragraph, but it is copied verbatim from values.yaml and reads the same as the neighbouring loadBalancerClass / ingressNameAdmin rows, so it is consistent with the file.

Document the platform value that sets the DNS suffix the dashboard
shows under the external IP of LoadBalancer Services. Only the next
trunk carries it: no released version has the key yet.

Assisted-by: LLM
Signed-off-by: Aleksei Sviridkin <f@lex.la>
@IvanHunters
IvanHunters merged commit 8017c1c into main Oct 5, 2026
3 checks passed
@IvanHunters
IvanHunters deleted the docs/publishing-service-domain branch October 5, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants