Repository navigation
Preserve ConvexError data in failed job results - #257
Open
ianmacartney wants to merge 2 commits into
Open
ianmacartney wants to merge 2 commits into
ianmacartney wants to merge 2 commits into
Conversation
commit: |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Member
Author
|
My only hesitation is whether |
reeceyang
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a queued function throws a
ConvexError, Workpool currently keeps only its message. Workflow cannot reconstruct the original error or expose its structureddata(convex/workflow#315).Add optional
errorDatato failedRunResultvalues and their validators. Both mutation workers and action/query workers preserve the original Convex value while keeping existing message formatting, retry decisions, andNonRetryableErrorbehavior. Ordinary errors and historical failures continue to work without the new field.Validation: all 245 tests pass, including callback round-trips for queries, mutations, and retried actions; build, typecheck, lint, and format checks pass. An isolated native-backend test with the corresponding Workflow changes also passed all five execution modes plus nested workflows, including bigint and byte payloads through replay.
Related: convex/workflow#315. Companion Workflow PR: convex/workflow#316 reconstructs
ConvexErrorfrom this payload.