Repository navigation
feat(benchsdk-runner): accept byStep hiddenSteps/hiddenMetrics in display manifests - #536
Merged
Merged
Conversation
…play manifests The benchmark run page's By Step section now renders toggleable per-step custom-metric breakdown rows and can start with some steps/metrics unchecked. A *.bench.ts manifest controls those defaults via display.byStep.hiddenSteps / .hiddenMetrics; validate the new keys as optional arrays of non-empty strings alongside defaultLayout. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
dtice25
marked this pull request as ready for review
October 23, 2026 00:19
Contributor License AgreementAll contributors are covered by a CLA. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The run page's By Step section is gaining per-step custom-metric breakdown rows and manifest-controlled default visibility, so a
*.bench.tsdisplayblock needs two new optional fields underbyStep:BenchmarkByStepDisplaygainshiddenSteps?: string[]/hiddenMetrics?: string[], andvalidateBenchmarkDisplayConfigwhitelists them and validates each as an array of non-empty strings — both are initial-state defaults only, so lenient string arrays match the existingdefaultLayoutposture. Companion UI change lives in benchmarks-platform; patch changeset included.Link to Devin session: https://app.devin.ai/sessions/0a0a5d5c02734562971dde00f3e08b54
Open in Devin Desktop: https://app.devin.ai/desktop/session/0a0a5d5c02734562971dde00f3e08b54?variant=devin
Requested by: @dtice25