Repository navigation
fix(volumes): verify marker fallback + sha manifest, timed() exit code, sandbox cleanup - #531
Closed
HeyGarrison wants to merge 1 commit into
Closed
HeyGarrison wants to merge 1 commit into
HeyGarrison wants to merge 1 commit into
Conversation
…e, sandbox cleanup Port of the stealth #18 fixes — same bug class, public repo copy: - verify: cat's newline-free marker glued onto the wc output, failing verify on intact data. Read either marker file, force a separator line, and hash-verify via a sha256 manifest captured in posix-probes - timed(): masked a failed dd behind the trailing echo's status, so dead writes still recorded throughput — now propagates rc - finally: a failed step left sandbox/secondSandbox running (billing + holding the volume open). Destroy every live ref with a bounded timeout; clear refs after the destroy step
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Devin Review findings on #528 — the public copy of
volumes.bench.tscarried the same three bugs already fixed in benchmarks-stealth #18:cat marker2.txt(no trailing newline) glued its output ontowc -c's count, solines[1]mismatched and persisted data read as a verify failure. Now reads either marker file (rename is an optional capability), forces a separator with; echo, and byte-verifies via a sha256 manifest captured in posix-probes — a size/count check can't see silent corruption on object-backed volumes.timed()masking failures: a failedddstill printedNS=and returned the trailing echo's exit status, recording throughput for a dead write. Now propagates the wrapped command's exit code (rc=$?; ...; exit $rc).sandbox/secondSandboxrunning — still billing and holding the volume open duringvolume-destroy. The finally block now destroys every live ref under a bounded timeout; refs are cleared after the destroy step.Link to Devin session: https://app.devin.ai/sessions/030c6248cef045b68395136f77112603
Open in Devin Desktop: https://app.devin.ai/desktop/session/030c6248cef045b68395136f77112603?variant=devin
Requested by: @HeyGarrison