Repository navigation
refactor: remove Windows support - #17
Merged
Merged
Conversation
showxu
enabled auto-merge (squash)
October 19, 2026 04:32
1 task done
showxu
added a commit
to computer-mcp/computer-mcp
that referenced
this pull request
Oct 19, 2026
## Summary The host now knows only generic plugin and host-service contracts, ahead of the module extraction. - **Windows**: deletes the Windows process, path and inspection implementations, the Windows process fixture and test branches, the `windows-core` CI job and its `validation_scope` input. Plugin platform declarations and executable paths share one closed vocabulary, which is `macos`; other platform names are rejected. - **Codex configuration migration**: deletes the import model, `config migrate-codex`, the `[codex]` configuration field, the startup guard, the example and `CodexMigration.md`. A leftover `[codex]` table is rejected by the existing unknown-field validation. - **Codex-specific host code**: deletes `computer-mcp codex …` (use `computer-mcp tools call` for any exposed tool), name-based host-action inference (protected host services require the declared `io.github.computer-mcp/host-action` metadata and fail closed otherwise), and the `codex.` prefix special cases in workspace requirements and read-only discovery. - **Tests and acceptance**: replaces tests that needed the external Codex plugin with fixture-based host-contract tests (including new HTTP reconnect ownership and Git dry-run callback regressions), removes the Codex probe and lifecycle checks from `Tools/Validation`, and makes release acceptance verify an installed package with read-only host checks. - **Documentation**: host copies of Codex runtime operations and diagnosis are replaced by links to [plugin-codex](https://github.com/computer-mcp/plugin-codex). `install codex`, the Codex skill roots and client registration stay. `Documentation/Decisions/` is unchanged. The builtin tool catalog snapshot has no differences. Merge after computer-mcp/plugin-codex#17 and the plugin change that takes over the Codex runtime documentation and end-to-end acceptance: the current plugin manifest still declares Windows and is rejected by this change. ## Validation - `swift-format` format and strict lint, `swift build`, `swift test` (1,407 core, 11 platform, 97 App tests), `verify-module-graph.py plan` and `package`, 94 Python tests, `verify-cli-interface.sh`, actionlint, DocC and localization checks, `Tools/Validation` tests, local CLI acceptance tests, ad-hoc `Scripts/build-app.sh`. - Catalog snapshot regenerated with `COMPUTER_MCP_UPDATE_CATALOG_SNAPSHOT=1`: zero differences. - Independent read-only review: approve. ## Documentation - [x] The documentation that owns this behavior is updated, or no change is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Computer MCP ships for macOS only (see the host's
Documentation/Decisions/PlatformScope.md), so this removes Windows support from the plugin with no change on macOS.#if !os(Windows)guards (reindentation only).Vendor/SwiftWindowsRuntime, the Windows tests, scripts and SQLite build, and the six Windows CI jobs.macosplatform and drops the Windows artifact; package-wide architectures stayarm64andx86_64.Sources/CodexAdapter/Resources/Protocol/is unchanged; remaining "windows" matches are vendor protocol declarations.Validation
swift build, 267 Swift tests, 27 Python tests, schema tests, formatting and lint, schema drift, package build and archive verification, isolated MCP check, actionlint, brand verification.arm64) is fixed.Documentation