Repository navigation
Conversation
v4 exposed every type in components/utils through ./component_utils/*. #947 restored CustomerCardsTemplateChildren for PaymentSource but not its twin AddressCardsTemplateChildren for Address, nor BaseFieldProps (OrderNumber) and TGenericChildrenProps (the *Field components), which needs TResources to be usable. The public-api spec cannot catch these: it checks runtime exports only and skips components/utils. Say so in its comment.
✅ Deploy Preview for commercelayer-react-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #947. v4 exposed every type in
components/utilsthrough./component_utils/*. #947 restoredCustomerCardsTemplateChildren(PaymentSource), but these types used by public props are still unreachable in v5:AddressCardsTemplateChildren: children-as-function of<Address>, the twin ofCustomerCardsTemplateChildrenBaseFieldProps: props ofOrderNumberTGenericChildrenProps+TResources: children-as-function ofLineItemField,SkuField,CustomerField,ParcelField,ParcelLineItemFieldandStockTransferField.TResourcesis needed to write the generic argument (TGenericChildrenProps<TResources["LineItem"]>)Spec comment
public-api.spec.tschecks runtime exports only and skipscomponents/utils, so it cannot catch any of these. Its comment now says so, and points at the hand-written list insrc/index.ts.Verification
pnpm typecheckcleanpnpm build: all four names are in theexport {}ofdist/index.d.ts🤖 Generated with Claude Code