Repository navigation
Send one payment method update per order at a time - #945
Merged
Merged
Conversation
✅ Deploy Preview for commercelayer-react-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
A click on a payment method label reaches a clickable <PaymentMethod> twice, and a click can land while the single-method auto-select is still setting the method, so the same order update went out twice at once. setPaymentMethod now joins a call for the method already being set and queues a call for another method behind the one in flight, so the order keeps the last selection.
malessani
force-pushed
the
fix/944-payment-method-double-patch
branch
from
November 20, 2026 16:22
602e6e6 to
40af761
Compare
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #944
A click on a payment method label reaches a clickable
<PaymentMethod>twice (label click, then the browser's click on the linked radio), and a click can land while the single-method auto-select is still setting the method. Both paths sent the samepayment_methodorder update twice at once.setPaymentMethod(inPaymentMethodReducer) now handles one update per order at a time, next to the existingsetPaymentSourcerequest coalescing: a call for the method already being set joins that request; a call for another method waits for it and goes out next, so the order keeps the last selection. Entries are removed once settled.PaymentMethodsContainer) and survives the component remounting, with no change to<PaymentMethod>itself.