Repository navigation
chore(toolchain): adopt Mojo 1.2.0 stable (max 26.7.0) - #128
Merged
Merged
Conversation
Bumps the pin from Mojo 1.1.0 / `max = "==26.6.0"` to Mojo 1.2.0 / `max = "==26.7.0"` on the stable channel. pixi.toml and pixi.lock move together; the lock resolves max 26.7.0 / mojo-compiler 1.2.0 on all three platforms, and `pixi install --locked` accepts it. No public Mojo signature changed, so downstream packages that compile against `src/` need no edits once they are on 1.2.0. Nothing failed to compile on any surface. The release's one new diagnostic is that `x^` passed to a borrowed parameter warns that the transfer has no effect, which --Werror makes fatal. Four `captures^` arguments to `JsPromise.on_settled` (which borrows `captures`) lose the `^`: three in src/addon/host_ops.mojo, and one in tests/compile/framework_coverage.mojo that only the coverage target reported. Nothing moved before, so behaviour is unchanged. CLAUDE.md gains a rule for it, and docs/MOJO-RULES.md is regenerated. `async`/`await` became `__async`/`__await` (a warning that marks async unstable). Here they appear only in comments, which now note the spelling. tests/cleanup_hook_observed.test.js failed under the Guard Malloc recipe on a clean tree since 0.17.0: the spawned child inherits DYLD_INSERT_LIBRARIES, and libgmalloc's banner landed in the stderr the test asserts empty. The test now strips only those banner lines. Verified on darwin-arm64 / Node 24.15.0: the addon, the coverage target, all three examples and the FFI probe are warning-clean under --Werror; 850 tests, 12 GC tests; the full suite and async_stress under Guard Malloc with MALLOC_STRICT_SIZE=1; codegen drift, kitchen sink and codegen example; the --Werror and keep-alive counterfactuals; docs, platform and self-test gates; CLI, tutorial and host-mode e2e; 18/18 benchmarks at 12-22% of ceiling. The non-required m0-interop job will fail its gate step until an m0 release is gated on Mojo 1.2.0; the pinned 0.2.0 compiles on 1.2.0 and passes parity 7/7. Full account in docs/toolchain-migrations.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pin from Mojo 1.1.0 /
max = "==26.6.0"to Mojo 1.2.0 /max = "==26.7.0"(stable channel, released 2026-10-22).pixi.tomlandpixi.lockmove together. No public Mojo signature changed, so@qkstat/retrieveand@qkstat/embedshould compile unmodified once they are on 1.2.0.What changed
x^passed to a borrowed parameter now warns that the transfer has no effect, and every CI compile is--Werror. Fourcaptures^arguments toJsPromise.on_settled(which borrowscaptures) lose the^. One of them was reported only by the compile-coverage target. Behaviour is unchanged, since nothing was moved before either.async/await→__async/__await(a warning that marks async unstable). Here they appear only in comments, which now note the new spelling.tests/cleanup_hook_observed.test.jshas failed under the Guard Malloc recipe since 0.17.0. libgmalloc's banner, inherited by a spawned child, landed in the stderr the test asserts empty. The test now strips only those lines.docs/MOJO-RULES.md), and there is an Unreleased CHANGELOG entry.docs/toolchain-migrations.mdgains a full 1.2.0 section.Verified locally (darwin-arm64, Node 24.15.0)
framework_coverage.mojo, all three examples and the FFI probe are warning-clean under--Werror.async_stress(40 × 80) also pass under Guard Malloc withMALLOC_STRICT_SIZE=1(banner confirmed).4/4, and the--Werrorand keep-alive IR counterfactuals both hold.pipeline.mojocollision, build-cache identity and-Iroots.globalCacheActive()andasyncRuntimeInitOk()are both stilltrue.Expected CI notes
m0-interop(non-required) will fail its gate step. No m0 on PyPI is gated on Mojo 1.2.0 yet (0.2.0 and the latest, 0.12.0, both list["1.1.0"]). The pinned 0.2.0 source compiles on 1.2.0 andparity.mjspasses 7/7 against it. MoveM0_VERSIONonce the re-gated m0 is published.ubuntu-latesttests) and the Deno and Bun 1.3.11 runtime gate can only be verified here. Locally, Bun 1.3.7 failsownThread/ownThreadTeardownidentically onmainbuilt with Mojo 1.1.0, so that comes from the old Bun.🤖 Generated with Claude Code