Autumn 2026 review - #246
Conversation
Added keypoints about GitHub Actions and CI/CD setup.
e352757 to
32be5c9
Compare
Related to first comment in coderefinery#245. Add lesson description in index as in the git intro https://coderefinery.github.io/git-intro/
also modified glossary
32be5c9 to
41d1870
Compare
stress automated vs non automated testing also, add definition of CI and common meaning of CI
301ae28 to
46749e1
Compare
continuous integration is a "difficult" expression, meaning originally the practice of merging into main/master/trunk often, then slightly abused because of GitLab CI. Co-Authored-by: Anja Virkkunen <anja.virkkunen@aalto.fi>
46749e1 to
e323393
Compare
johanhellsvik
left a comment
There was a problem hiding this comment.
Good editing and additions to the lesson contents. Highlighting here a few things that I think are good improvements
- The new contents under "In this lesson we discuss the basics of automated testing." read well.
- The extended "Testing vocabulary" is most valuable.
- The change of wording "continuous integration" -> "cloud" as in the change"Exercise CI-1: Create and use a continuous integration workflow on GitHub or GitLab" to "Exercise CI-1: Create and use a workflow on GitHub or a pipeline on GitLab" is good for clarity. I agree that the expression "continuous integration" can have different meanings in different contexts.
My only specific suggestion for change/addition is that one could perhaps somewhere that a workflows/pipelines need not necessarily be on the cloud, but could alternatively be on e.g. a self hosted GitHub or GitLab server.
| This exercise can be run in "collaborative mode" by following instead the instructions | ||
| in [Full-cycle collaborative workflow](./full-cycle-ci). In the collaborative version steps | ||
| C-D below are performed by a collaborator. | ||
|
|
||
|
|
||
| ```{challenge} Exercise CI-1: Create and use a continuous integration workflow on GitHub or GitLab | ||
| ```{challenge} Exercise CI-1: Create and use a workflow on GitHub or a pipeline on GitLab |
There was a problem hiding this comment.
This exercise is rendered inside the above note, is that intentional?
I'm looking at this: https://mmesiti.github.io/cr-testing/branch/aut2026review/cloud/
I don't know enough sphinx syntax to resolve this.
There was a problem hiding this comment.
It would be sufficient to add a "" before the challenge block, to properly close the note block. But I can't do this on github with a suggestion, interestingly, because the additional in the suggestion would close the suggestion block instead of being added to the document, and I don't know how to "escape" the "```" so that this doesn't happen...
There was a problem hiding this comment.
Should be fixed now (done locally)
Vinye
left a comment
There was a problem hiding this comment.
I did a proofreading of the changes, caught some minor things 🔎
Co-Authored-by: Anja Virkkunen <anja.virkkunen@aalto.fi> Co-authored-by: Michele Mesiti <mmesiti@users.noreply.github.com>
50c55a3 to
f7c23e7
Compare
|
Thank you @johanhellsvik for the prompt review!
This made me think a bit. I would have argued that a self hosted github or gitlab server would still qualify as cloud (might be a "private" cloud), BUT I realised that I might be using "cloud" in an improper way (in the same way I thought that "continous integration" was used slightly ambiguously before, so we decided to get rid of the term). Maybe a more elegant approach would be to get rid of "cloud" and just say "remotely", so we would have What do you think? Poking @Vinye since she was definitely part of the discussion. |
|
After fixing the cloud/remote wording issue (waiting on your opinion), there are 2 alternative ways to go forward:
What do @Vinye and @johanhellsvik think? Sorry for spamming mentions. |
first we removed "Continous integration" because of the ambiguity but then we replaced it with "cloud", which is also not very clear. "remote/remotely" is probably the cleanest approach here.
While this is true, for me the word "cloud" first associates with the big providers and it doesn't connect in my head with self-hosting. Remotely is a fine choice, although another word that came to my mind is server, how about it? Also, now that we are thinking about our word choices to accomodate self-hosting, should we mention self-hosting as an option somewhere? Along the lines of "besides Github Actions and Gitlab pipelines, self-hosting your test servers is also an option, but we won't cover that here" P.S. I'd prefer merging this (option 1) |
|
I'd merge this. There will be chances to do further review for another batch of changes. @Vinye ok? |
|
OK |
This is being addressed in #252 |
Addressing comment in coderefinery#246 (review)
Tries to address all issues in #245.
This PR will contain many independent bits, please use the code review feature to choose which changes should be approved.
I will add comments there too.
View the content rendered: https://mmesiti.github.io/cr-testing/branch/aut2026review/cloud/ (haven't thanked @frankier for finding and showing me the trick to see the rendering of branches other than
main, and also @rkdarst for adding that feature to the github workflow).I can't add @Vinye to the reviewers it seems, but she's definitely got a say here :-)
Updated 10.09 with link to rendered pages