Conversation
|
Pre-view the result: https://mmesiti.github.io/cr-documentation/branch/gitlab-ci-1/gh_workflow/ |
| ## Alternatives to GitHub and GitLab Pages | ||
|
|
||
| - [Read the Docs](https://readthedocs.org) is the most common alternative to | ||
| hosting in GitHub Pages. |
There was a problem hiding this comment.
| hosting in GitHub Pages. | |
| the two solutions presented above. |
|
One thing I would suggest to improve is that the workflow recipes install from a requirements.txt or environment.yml instead of listing the dependencies explicitly. But I know that your PR here did not introduce this so perhaps it should not need to fix it. Motivation for rather using requirements.txt/environment.yml:
But this can become its own issue and does not have to delay this PR. |
I think it would be better but
Edit: added #351 and issues/PRs therein |
Updated the workflow to install dependencies from requirements.txt instead of hardcoding them. Also, Added instructions about changing requirements.txt adding sphinx-autodoc2 and myst-nb packages in the relevant exercises.
4cf9ba2 to
566f33b
Compare
|
Changed to draft because Discovered that the GH-2 exercise is actually not compatible with the GitLab track. Interestingly, if we merged #351 first, we would not have this problem, since the environment setup would be delegated requirements.txt, so we don't have to change anything workflow/pipeline definition files. Rebasing this onto #351 |
Turns out this was a smell with interesting consequences :-) |
from https://github.com/mmesiti/cr-best-practices-in-rse/blob/98b7940782ff1c3cdfb55a433e9d60f735b8f94c/content/gh_workflow.md
Addresses #342
Should go in the direction of coderefinery/git-intro#535
Update: Discovered that the #2 exercise is actually not compatible with the GitLab track. @bast 's suggestion fixes this, rebased this branch on top of #351 . Merging this would also merge #351, so changing this to draft until #351 is merged.