fix: prevent UnicodeDecodeError from non-UTF-8 git paths - #783
Open
sentry[bot] wants to merge 1 commit into
Open
fix: prevent UnicodeDecodeError from non-UTF-8 git paths#783sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-BD, where the Codecov CLI would crash with a
UnicodeDecodeErrorwhen encountering git repositories containing filenames with non-UTF-8 byte sequences.The root cause was identified in
codecov_cli/helpers/versioning_systems.py, specifically in thelist_relevant_filesfunction. The output ofgit ls-fileswas being decoded using a bare.decode()call, which defaults to UTF-8 and raises an error when invalid byte sequences are encountered.The fix involves adding
errors='surrogateescape'to the.decode()call. This error handling strategy allows undecodable bytes to be represented as Unicode surrogate characters, preventing theUnicodeDecodeErrorand ensuring that the CLI can process repositories with such filenames without crashing, while preserving the original byte information.Fixes CLI-BD
This PR was automatically generated by Sentry. You can adjust this setting at any time.