Skip to content

V10.8.0/options enhancement - #172

Merged
gimlichael merged 29 commits into
mainfrom
v10.8.0/options-enhancement
Oct 3, 2026
Merged

gimlichael merged 29 commits into
mainfrom
v10.8.0/options-enhancement

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request adds AddConfiguredOptions<TOptions> to connect Cuemon Parameter Object conventions with the Microsoft Options lifecycle. It exposes the primary configurator and cached default options instance, with expanded regression coverage for configuration, post-configuration, validation, and service lifetimes.

Configured options integration:

  • Register Parameter Object post-configuration and validation through Microsoft Options while preserving named options behavior and framework lifecycles.
  • Expose the exact primary setup delegate and direct default options resolution; ignore repeated registrations for the same options type.
  • Cover success, exception, ordering, and lifetime behavior in service collection tests.

Options documentation and release notes:

  • Explain the API lifecycle, ordering, validation behavior, and interaction with ordinary Microsoft configuration.
  • Add a consumer example and record the API in package release notes and the changelog.

CI and repository workflow guidance:

  • Remove the obsolete CI pipeline and update contributor guidance for the current PR, release, and deployment workflow structure.
  • Clarify local bot workspace handling and update repository references accordingly.

gimlichael and others added 10 commits September 23, 2026 16:39
Connect Parameter Object post-configuration and validation conventions to Microsoft Options while exposing the primary configurator and cached default options instance.
Explain how Cuemon parameter object conventions participate in Microsoft Options lifecycles and provide a consumer-ready example for the new registration method.
Record the new options registration API and its Parameter Object integration in the package release metadata.
Document the surviving API and CI workflow changes for release review.
@gimlichael gimlichael self-assigned this Oct 2, 2026
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[High risk] Adds CI/CD workflows and dependency updates across the library.

The PR should not merge until the outstanding requirement concerning the tracked .bot workspace guide is satisfied.

Fix All in CodexFindings

  1. P2 Tracked bot workspace guide ▶
Fix with agent prompt
### Issue 1
.bot/README.md:undefined-1
This adds a tracked guide for a local-only bot workspace. The repository’s public-API documentation directive limits new working-tree files to the managed AGENTS block, active DocFX configuration, an approved waiver, or DocFX namespace and type pages. This file is outside those categories, so the repository requirement must be satisfied before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR adds Parameter Object integration with Microsoft Options, expands lifecycle tests and documentation, and separates PR validation, release, and deployment workflows. Since the previous review, it narrows Codecov secret forwarding, rechecks the live release tag before publication, preserves both disposal failures, and updates contributor guidance.

Reviews (8) · Last reviewed commit: "update cl"

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread src/Cuemon.Extensions.DependencyInjection/ParameterObjectOptions.cs Outdated
Align the documented Linux CI runner baseline with the workflows.
Move pull request and downstream release workflows to the current Ubuntu runner image.
Comment thread .bot/README.md
@@ -0,0 +1,10 @@
# .bot Workspace

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Tracked bot workspace guide

This adds a tracked guide for a local-only bot workspace. The repository’s public-API documentation directive limits new working-tree files to the managed AGENTS block, active DocFX configuration, an approved waiver, or DocFX namespace and type pages. This file is outside those categories, so the repository requirement must be satisfied before merging.

Context Used: AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: .bot/README.md
Line: 1

Comment:
**Tracked bot workspace guide**

This adds a tracked guide for a local-only bot workspace. The repository’s public-API documentation directive limits new working-tree files to the managed AGENTS block, active DocFX configuration, an approved waiver, or DocFX namespace and type pages. This file is outside those categories, so the repository requirement must be satisfied before merging.

**Context Used:** AGENTS.md ([source](https://github.com/codebeltnet/cuemon/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex

Let cancellation from options validation reach the caller so canceled work is not reported as an ordinary validation failure.
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (d0da548) to head (fca2b1d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   94.23%   94.18%   -0.05%     
==========================================
  Files         604      605       +1     
  Lines       19707    19089     -618     
  Branches     2103     1831     -272     
==========================================
- Hits        18570    17979     -591     
- Misses       1073     1083      +10     
+ Partials       64       27      -37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Run unmanaged cleanup even when managed cleanup throws, while preserving the original exception and ensuring disposal remains idempotent.
Align the shared test coverage and SQL client dependencies with their updated patch and minor releases.
Move Codecov upload to the shared reusable workflow so pull request CI uses the centralized job definition.
Record the 10.8.0 package changes and compatible dependency updates in each affected package release note.
Update the release date and summarize the shipped options integration, disposal fix, dependency updates, and workflow changes for repository readers.
Comment thread .github/workflows/pr.yml Outdated
Comment thread src/Cuemon.Kernel/Disposable.cs Outdated
Comment thread .nuget/Cuemon.Core/PackageReleaseNotes.txt
aicia-bot and others added 5 commits October 3, 2026 12:22
Local midnight can already be in the past when interpreted as UTC on runners west of UTC. Derive validity windows from one UTC timestamp so future-start and expiry rejection checks remain reliable while preserving signature and tampering assertions.
Scheduler overhead on loaded CI runners can exceed the shared 500 ms latency budget before retries complete. Use the default budget for retry behavior tests and reserve the strict limit for dedicated latency tests, preserving retry counts, results, and exception assertions.
Trigger releases from version tags and validate their identity and main history before publishing. This keeps the released commit tied to the tag that initiated the workflow.
Validate the published release assets and resolve the tag to its source commit before promoting the DocFX image. This ties the registry artifact to the verified release identity.
Comment thread .github/workflows/release.yml
Comment thread .github/CONTRIBUTING.md Outdated
aicia-bot and others added 6 commits October 3, 2026 21:43
The 10.8.0 entry described workflows that no longer match the repository, so this corrects the summary to cover the tag-validated release workflow, DocFX image deployment, the pull-request pipeline rename, and the test timing fixes, and drops the stale Unreleased link now that the version is cut.
When managed and unmanaged cleanup both fail, preserve both exceptions while still invoking each cleanup hook once.
Publishing the draft must re-resolve the remote tag and match it to the SHA whose packages and image were validated.
Reusable Codecov workflows now get the upload token through an explicit secret mapping, keeping other workflow secrets out of those calls.
This documents the tag-driven package release and verified image handoff, including how maintainers can retry safely after partial publication.
@gimlichael
gimlichael merged commit 33e6e75 into main Oct 3, 2026
322 of 323 checks passed
@gimlichael
gimlichael deleted the v10.8.0/options-enhancement branch October 3, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants