Repository navigation
fix(demo): show the OpenStreetMap attribution and drop the default e2e API key - #148
Merged
Merged
Conversation
…e API key The demo now shows the copyright notice and a link for vector layers sourced from OpenStreetMap. It is built with DOM APIs, so the data stays text. The legacy e2e test reads the Google key only from the environment and runs without one. A static test keeps key-shaped strings out of tracked files and pins the secret scanning exclusions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kochizufan
marked this pull request as ready for review
October 30, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
© OpenStreetMap contributorsand a link to the OpenStreetMap copyright page next to vector layers whose source is OpenStreetMap. The text and link are built with DOM APIs, so noinnerHTMLis added.e2e/maplat-legacy.spec.tsreads the Google key only fromGOOGLE_MAPS_API_KEYand has no default. The test passes without a key because it never switches to a Google map..github/secret_scanning.ymlno longer excludesindex.html.spec/no-google-api-key.spec.tschecks tracked files for key-shaped strings and pins the five remaining exclusions. On failure it reports file names only.src/and.github/workflows/test.ymlare unchanged.Verification
spec/no-google-api-key.spec.tse2e/nov26-m4-t8-demo.spec.ts, attribution testse2e/maplat-legacy.spec.tswithout a keyvitest runtsc --noEmiteslint src specThe E2E runs used
--trace off --reporter line, and their output held no key-shaped strings.🤖 Generated with Claude Code