Repository navigation
docs(testkit): describe the reflected E2E GCP set (fixture 1.0.1) - #5
Merged
Merged
Conversation
…sion to 1.0.1 The recommended E2E GCP set maps pixel y-down to north-up, so the mapping reverses orientation. Clarify that it fits a similarity exactly only through chirality normalization on the caller side, and that fitWorldFile on its own returns the six affine values. Numeric constants are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/testkit/mockContractFixture.ts: the set maps pixel y-down to north-up, so the mapping contains a reflection. It fits a similarity exactly only when the caller applies chirality normalization (fitting the pixel-v-negated input as well);fitWorldFileon its own adopts affine and returns the same six values.fixtureVersionto1.0.1. No numeric constant changes (the diff touches only doc-comment lines and the version line).New SHA-256 of the fixture:
5da3d253e46a0dc6f8710432fc0783a261fbb35ca0c47757b0b204a48fa85495.Merge order
Teiresias keeps a byte-identical copy of this fixture and checks the SHA against its sibling Daedalus. Merge this PR immediately before the matching Teiresias PR (same branch name
dec26/m1-t2-chirality), re-run the Teiresias CI after this merge, and do not merge other Teiresias PRs in between.Test plan
pnpm run test(46 passed),typecheck,build,test:typesexit 0 locally🤖 Generated with Claude Code