Repository navigation
docs: warn against estimating with rows of other celestial bodies - #7
Merged
Merged
Conversation
The note on includeOtherCelestialBodies now also covers passing such rows through createCandidateTransformer to the estimateCrs of Teiresias, which transforms every candidate it is given. The README in both languages and the option's JSDoc (and the rebuilt declaration in dist) say the same. No behaviour changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kochizufan
marked this pull request as ready for review
October 27, 2026 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The note on
includeOtherCelestialBodies(rows of the Moon, Mars, ... kept on request) used to say only "do not pass such rows totransformLonLatArrayToProjectedin bulk". It now also covers the adapter path: do not pass them throughcreateCandidateTransformerto theestimateCrsof Teiresias.estimateCrstransforms every candidate it is given, so the runtime can stop answering. With Teiresias failing the whole estimate on any implementation-side candidate failure, a failed transformation also makes the estimate fail.README.md/README.ja.md: the bullet in "CRS of other celestial bodies"src/proj-wasm-crs.ts: the JSDoc ofincludeOtherCelestialBodies, plus the rebuiltdist/proj-wasm-crs.d.tsNo behaviour changes.
Checks (local)
build,typecheck,verify:demo,verify:packed-browser: exit 0;git status --short distis clean after the build.testhit the existing 9 s / 16 s per-test timeouts of three proj-wasm tests while the machine was heavily loaded (load average above 200). This change does not touch runtime code; see CI for the test run.🤖 Generated with Claude Code