Repository navigation
Expose sampled elevation seas in Python WEC API - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Expose WEC-Sim's sampled time/elevation MAT input as
ImportedElevationWavethrough the public PythonWECbuilder. The generalized linear-subspace solver uses the already pairedBodyClass.userDefinedExcitationconvolution, accepts named MAT variables, records the file in provenance, and permits an explicit second force ramp for source-compatible comparisons.Validation
Local Python API and dynamics suite: 29 passed. The imported-elevation API test covers a configurable two-body PTO.
actionlintpasses.The new derived Sphere benchmark changes only the pinned
Free_Decay/0msea to a reproducible two-frequency sampled elevation, then compares 4,001 MATLAB and Python samples of wave elevation, six excitation-force components, heave, and speed. The fresh R2025b run with tightened gates passed. Maximum observed differences were6.7e-15m wave,3.7e-9N or N m force, 0.0243 mm heave, and 0.0323 mm/s speed. Explicit paired gates are1e-12m,1e-6N or N m, 0.1 mm, and 0.1 mm/s. The tightened test also passes against the downloaded live artifact. The existing RM3 MooringMatrix paired source and trajectory tests pass locally after the refactor. A built wheel importswecsim.ImportedElevationWaveoutside the checkout.This does not alter the source-specific RM3 MooringMatrix floating-joint solver or resolve the separate RM3 state-space Cases 5 and 6 question.