Repository navigation
Document ellipsoid ode45 source-sampling gap - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Nonlinear_Hydro/ode45baselines, Regular and RegularCIC, with saved body, PTO, wave, and force histories.Finding
The physical inputs are identical to the published ode4 cases except for the MATLAB solver. In both ode45 runs, logged restoring force at sample i equals mesh buoyancy evaluated at body state i-1 within 6e-9 N, while its current-state mismatch exceeds 54 kN. The logged total force includes this lagged term, and the adjusted Simscape mass times logged acceleration agrees with total plus PTO force within 2e-9 N. Drag and excitation remain current-state forces. The source's ode4 and ode45 trajectories differ by up to 15.9 mm heave and 35.4 kN PTO force.
Python continues to apply instantaneous buoyancy. Its ode45-source comparisons are within 19.94 mm heave and 36.05 kN PTO force over 150 s, but this is recorded as a solver-envelope diagnostic, not ode45 numerical parity. No delay or coefficient tuning was added to Python.
Verification
actionlintandgit diff --checkpassed.SungJun Won's original commits remain in branch ancestry.