chore: upgrade actions to Node 24 runtime (SHA-pinned) - #36
chore: upgrade actions to Node 24 runtime (SHA-pinned)#36John C. Bland II (johncblandii) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the deploy GitHub Actions workflow to use SHA-pinned versions of key actions/* steps intended to run on the newer Node 24 runtime, aligning with supply-chain hardening via commit pinning.
Changes:
- Replace
actions/checkout,actions/setup-node, andactions/setup-pythonversion tags with SHA-pinned references plus version comments. - Standardize action references to explicit commits to avoid implicit runner/runtime changes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| - uses: actions/setup-python@v5 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| - uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 |
Erik Osterman (Cloud Posse) (osterman)
left a comment
There was a problem hiding this comment.
Approving. Three pins verified against upstream tags, no action.yml / Dockerfile / permissions / release-config changes, so zero downstream impact.
Worth knowing this change is currently inert: the job being pinned is if: false # disable for now (pre-existing), which is also why the checks skip rather than exercise it. That same disabled job holds run: make push with env: GH_TOKEN: ${{ secrets.PAT }} — nothing here weakens it, but it deserves a fresh look if it's ever re-enabled.
Also: action.yml already declares using: 'node24', so this repo never needed the runtime upgrade the title describes.
what
SHA-pinned with precise version comments:
actions/checkout@v4→@3d3c42e5...# v7.0.1actions/setup-node@v4→@82076278...# v7.0.0actions/setup-python@v5→@5fda3b95...# v7.0.0why
are already being force-migrated to Node 24
matching the org's direction in chore: upgrade actions to Node 24 runtime and enforce SHA pinning .github#261
references